Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sort icon for primary FAB action #711

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Sep 6, 2023

Pull Request Description

In #670, we agreed to use a generic sort icon in the AppBar and FAB. One place that was overlooked was when the Change Sort action is the primary action for the FAB. This PR fixes that case so that it also shows the generic icon.

P.S. I am also working on a change to show the specific icon in the AppBar, next to the text description, as suggested here.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Before After
image image
image image

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 786314a into thunder-app:develop Sep 7, 2023
1 check passed
@micahmo micahmo deleted the fix/sort-icon-fab branch September 7, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants