New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve text/labels on profile page #715

Merged

hjiangsu merged 2 commits into thunder-app:develop from micahmo:feature/profile-string-improvements

Sep 7, 2023

Member

micahmo commented Sep 7, 2023 •

edited

Loading

Pull Request Description

Localize profile page.
Add semantic label for history button (@shortwavesurfer2009).
Per suggestion from Matrix chat, change "History" to "Overview".

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Checklist

Did you update CHANGELOG.md?
Did you use localized strings where applicable?
Did you add semanticLabels where applicable for accessibility?

micahmo added 2 commits

September 6, 2023 23:01


          Improve text/labels on profile page

670ac40


          Change 'history' to 'overview'

9c4888e

hjiangsu approved these changes

View reviewed changes

Member

hjiangsu left a comment

LGTM!

hjiangsu merged commit 4d91b89 into thunder-app:develop

1 check passed

micahmo deleted the feature/profile-string-improvements branch

September 7, 2023 17:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment