Show sort icon in header/settings #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
PR #670 removed the sort icon in the AppBar in favor of a more generic icon. While I think this was a good change and follows general design patterns more closely, I had gotten used to glancing the icon to see the current sort mode. This PR adds that icon back next to the text description under the heading (and settings page). I think this is a nice change both for Thunder users who are already familiar with the icons and to distinguish the app a bit more from others.
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
qemu-system-x86_64_V7s0AVe8HI.mp4
Checklist
semanticLabels where applicable for accessibility?