Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pin/favorite/locked icons #719

Merged
merged 3 commits into from
Sep 10, 2023

Conversation

CTalvio
Copy link
Collaborator

@CTalvio CTalvio commented Sep 7, 2023

Pull Request Description

Just adds a 3.5 width sizedbox between the icons and the title when they are present.

Issue Being Fixed

It looks a little lopsided.

Screenshots / Recordings

Screenshot_20230907_231246

Before and after.

Screenshot_20230907_232030

Checklist

  • Did you update CHANGELOG.md?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one question...

It looks like there is already some code which adds space after the lock icon if the post is not also saved and pinned. Now with your change, will there be double space for only-locked posts? Maybe this can be removed?

if (!postViewMedia.postView.post.featuredCommunity && (useSaveButton || !postViewMedia.postView.saved))
const WidgetSpan(
child: SizedBox(
width: 3,
)),

@CTalvio
Copy link
Collaborator Author

CTalvio commented Sep 8, 2023

LGTM! Just one question...

It looks like there is already some code which adds space after the lock icon if the post is not also saved and pinned. Now with your change, will there be double space for only-locked posts? Maybe this can be removed?

if (!postViewMedia.postView.post.featuredCommunity && (useSaveButton || !postViewMedia.postView.saved))
const WidgetSpan(
child: SizedBox(
width: 3,
)),

Didn't notice that, I'll check that out when I have time.

@CTalvio
Copy link
Collaborator Author

CTalvio commented Sep 9, 2023

Done

@micahmo
Copy link
Member

micahmo commented Sep 10, 2023

LGTM now! There is a build error, but it's not your fault (fixig in #726), so I'll go ahead and merge this.

@micahmo micahmo merged commit b0312ec into thunder-app:develop Sep 10, 2023
1 check failed
@CTalvio CTalvio deleted the fix_icon_padding branch January 28, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants