Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide community name and show username in community view #724

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Sep 9, 2023

Pull Request Description

This PR fixes #303 by hiding the community name in the post metadata when we're viewing a specific community. Also as suggested by this comment, in order to fill the empty space, the username is shown instead.

Issue Being Fixed

Issue Number: #303

Screenshots / Recordings

image

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 0549ee6 into thunder-app:develop Sep 11, 2023
1 check passed
@micahmo micahmo deleted the fix/303-usernames-in-community branch September 11, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants