Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for username/community mentions #751

Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Sep 20, 2023

Pull Request Description

This is a first-pass implementation for adding easier username and community mentions in the comment and post editor. For this first pass, mentions can be initiated via editor buttons and a popup dialog.

In the future, it would be nice to detect that a username/community is being mentioned while typing (@/!) and show relevant results inline based on what has been typed (like the web UI). That will be a bit more work, so I figured we could get the groundwork in place here (and I also did some refactoring to that end).

Note that thunder-app/markdown-editor#3 must be merged first, then I'll update pubspec.yaml here.

Review without whitespace.

Issue Being Fixed

Issue Number: Related to #256 and #500, but not a complete solution.

Screenshots / Recordings

qemu-system-x86_64_7iDUMAi5QD.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@micahmo
Copy link
Member Author

micahmo commented Oct 2, 2023

Updated to use the merged package ref from the official repo, so this one should be good to go!

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This isn't directed towards this PR in particular but I'm just keeping a mental note to refactor/extract the MarkdownButtons into its own separate widget to have less repeated code in the codebase!

@hjiangsu hjiangsu merged commit af1eba9 into thunder-app:develop Oct 2, 2023
1 check passed
@micahmo micahmo deleted the feature/username-community-mentions branch October 2, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants