Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle issue where failing to retrieve image dimensions blocks post loading #761

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Handle issue where failing to retrieve image dimensions blocks post loading #761

merged 3 commits into from
Sep 22, 2023

Conversation

Fmstrat
Copy link
Contributor

@Fmstrat Fmstrat commented Sep 22, 2023

Pull Request Description

Addition of a missing try/catch to keep post pulling from locking up on image load failure.

Issue Being Fixed

Issue Number: #740

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@Fmstrat
Copy link
Contributor Author

Fmstrat commented Sep 22, 2023

Hrm, for some reason the linter isn't showing me the actual error here?

@hjiangsu
Copy link
Member

Ahh, make sure to run dart format -l 200 and it should pass the linter tests!

hjiangsu
hjiangsu approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 69e7eff into thunder-app:develop Sep 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjiangsu hjiangsu hjiangsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Fmstrat @hjiangsu