Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/auth bloc error handling #770

Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Sep 26, 2023

Pull Request Description

This PR adds instance/network error handling to the AuthBloc so that we can detect issues as early as the first API request (that is, checking for downvotes enabled).

Note that this does not replace the similar handling in the CommunityBloc.

This PR supercedes #769.

I also updated some timeouts throughout the app to be more consistent.
I also added a new helper method to translate exceptions to messages.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

qemu-system-x86_64_VppEu146vv.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Sorry again for introducing this issue with my previous feature for checking instance downvotes 😅

@hjiangsu hjiangsu merged commit 18680cc into thunder-app:develop Sep 27, 2023
1 check passed
@micahmo micahmo deleted the feature/auth-bloc-error-handling branch September 27, 2023 14:43
@hjiangsu hjiangsu mentioned this pull request Apr 10, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants