Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interactions with saved comments #779

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Sep 27, 2023

Pull Request Description

Similar to #424, this PR adds support for interacting with comments (upvote/downvote/save) in both the Overview (self comments) and Saved section of the user profile (including comments that are in both sections, i.e., self comments that are saved). I also fixed an issue I found where the poster of every comment was identified as the current user.

Issue Being Fixed

Issue Number: #776

Screenshots / Recordings

comment-fixes.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Collaborator

@ggichure ggichure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 0246fb5 into thunder-app:develop Oct 3, 2023
1 check passed
@micahmo micahmo deleted the fix/776-interact-saved branch October 4, 2023 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants