Fix accessibility semantics for replies/saved #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shortwavesurfer2009 Apologies for not including audio in the original recording! Let me know if you can hear this recording and whether the screen reader is doing what you expect. |
|
AH, THAT IS PERFECT!
Sent from Proton Mail mobile
…-------- Original Message --------
On Sep 29, 2023, 10:54 AM, Micah Morrison wrote:
***@***.***(https://github.com/shortwavesurfer2009) Apologies for not including audio in the original recording! Let me know if you can hear this recording and whether the screen reader is doing what you expect.
https://files.catbox.moe/blv5tt.mkv
—
Reply to this email directly, [view it on GitHub](#782 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/A33HFOT5GZL7PAPG5UZMXZDX43OJNANCNFSM6AAAAAA5KJXWWY).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
NOTE: We discovered that this PR removes the ability to click links from a reply. The links can still be clicked by opening the reply in context view which turns it into a comment. |
@shortwavesurfer2009 Is this PR good with you given this issue? From what I read in the Matrix chat, it seems like its okay but just wanted to double check! |
hjiangsu
approved these changes
Oct 3, 2023
|
Yeah, this will be alright
Sent from Proton Mail mobile
…-------- Original Message --------
On Oct 3, 2023, 2:19 PM, Hamlet Jiang Su wrote:
> NOTE: We discovered that this PR removes the ability to click links from a reply. The links can still be clicked by opening the reply in context view which turns it into a comment.
***@***.***(https://github.com/shortwavesurfer2009) Is this PR good with you given this issue? From what I read in the Matrix chat, it seems like its okay but just wanted to double check!
—
Reply to this email directly, [view it on GitHub](#782 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/A33HFOUHM4776H44C6PBPSLX5RJKNAVCNFSM6AAAAAA5KJXWW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBVGQ4TCOJYGY).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This fixes an issue with screen reader accessibility in saved/replied comments. The fix is to read the whole post and comment info in one element. The only other element would be the mark as read button, if applicable.
@shortwavesurfer2009 Could you take a look and see if this is what you had in mind?
Issue Being Fixed
Issue Number: #777
Screenshots / Recordings
replies-fix.mp4
Checklist
semanticLabels where applicable for accessibility?