Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FAB hatics #800

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Oct 3, 2023

Pull Request Description

This PR tweaks the haptic feedback that occurs when long-pressing the FAB. Instead of only activating when the long-press threshold has been met, there is now feedback as soon as the button is pressed and when the long-press kicks in.

I believe all other interactions with the FAB already have feedback.

Issue Being Fixed

Issue Number: #780

Screenshots / Recordings

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit eebe0f5 into thunder-app:develop Oct 3, 2023
1 check passed
@micahmo micahmo deleted the fix/780-fab-haptics branch October 4, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants