Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show trending communities on search page #807

Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Oct 5, 2023

Pull Request Description

This PR shows trending communities on the search page before a query is made. This should correspond to the trending communities shown on the web UI.

All other search features (like responding to instance changes, supporting subscribing/unsubscribe) should work with trending.

Review without whitespace.

Issue Being Fixed

Issue Number: Related to #646

Screenshots / Recordings

qemu-system-x86_64_tRau2uRNgK.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@micahmo micahmo force-pushed the feature/trending-communities-on-search branch from 7686a0d to ff53ea0 Compare October 5, 2023 04:45
Copy link
Collaborator

@ggichure ggichure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 21f217f into thunder-app:develop Oct 10, 2023
1 check passed
@micahmo micahmo deleted the feature/trending-communities-on-search branch October 10, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants