Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve URL handling in post creator #812

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Improve URL handling in post creator #812

merged 1 commit into from
Oct 9, 2023

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Oct 8, 2023

Pull Request Description

This PR fixes an issue where a poorly formatted URL could either...

  • Cause the create post screen to become unusable (because the parsing would throw an exception and the same contents would always be loaded from drafts)
  • Or cause the post to be lost when attempting submission because Lemmy would reject it

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Before

urls_before.mp4

After

urls_after.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

ggichure
ggichure approved these changes Oct 8, 2023
View reviewed changes
Copy link
Collaborator

@ggichure ggichure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@micahmo micahmo changed the title Improve URL handling is post creator Improve URL handling in post creator Oct 8, 2023
hjiangsu
hjiangsu approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 1b5ad94 into thunder-app:develop Oct 9, 2023
1 check passed
@micahmo micahmo deleted the fix/post-bad-urls branch October 10, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjiangsu hjiangsu hjiangsu approved these changes

@ggichure ggichure ggichure approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@micahmo @hjiangsu @ggichure