Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support navigating to posts from within the app #818

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Support navigating to posts from within the app #818

merged 2 commits into from
Oct 17, 2023

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Oct 11, 2023

Pull Request Description

This PR adds support for in-app post navigation.

Note that this does not add support for handling Lemmy links outside the app, although I think we're getting close to that possibility. 馃槉

Issue Being Fixed

Previously, links to posts would open in the browser.

Issue Number: N/A

Screenshots / Recordings

qemu-system-x86_64_jZt2aIpeey.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@ggichure ggichure mentioned this pull request Oct 16, 2023
Merged
8 tasks
@hjiangsu hjiangsu merged commit ec332ed into thunder-app:develop Oct 17, 2023
1 check passed
@micahmo micahmo deleted the feature/in-app-post-navigation branch October 17, 2023 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjiangsu hjiangsu hjiangsu approved these changes

@ggichure ggichure ggichure approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@micahmo @hjiangsu @ggichure