Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to create post without being in community feed #836

Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Oct 17, 2023

Pull Request Description

This PR adds support for initiating a new post without an existing community context (i.e., from home feed) and allowing the user to select any community to post to.

Note: This could lead into a feature where we can share any link to Thunder and create a new post from it, as suggested in #639.

Note: Technically, this change allows you to initiate a new post within a given community and then change to a different target community. I don't think this is necessarily a bad thing though.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

qemu-system-x86_64_Z3vwdUU01y.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

One feature that we could add (doesn't have to be in this PR of course) would be to have a pre-generated list of suggestions based on the communities that the user is subscribed to. This way, the user can easily select one of their subscribed communities to post to rather than having to type them in!

We do keep a list of the user's subscriptions in AccountState so this could be used in this case to reduce further API calls.

@micahmo
Copy link
Member Author

micahmo commented Oct 19, 2023

One feature that we could add (doesn't have to be in this PR of course) would be to have a pre-generated list of suggestions based on the communities that the user is subscribed to.

Good idea!! Done in e659566.

qemu-system-x86_64_hpDWn5EP56.mp4

@hjiangsu
Copy link
Member

Looks good! I just realized I made a typo with subscriptions (should be subscriptions instead of subsciptions)

@hjiangsu hjiangsu merged commit 12564cb into thunder-app:develop Oct 19, 2023
1 check passed
@micahmo micahmo deleted the feature/create-post-before-community branch October 19, 2023 17:03
@micahmo micahmo mentioned this pull request Oct 19, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants