Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more search options #845

Merged
merged 5 commits into from
Oct 29, 2023
Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Oct 21, 2023

Pull Request Description

This PR enhances the search page.

New chips have been added under the text box. (See Gmail for the UI inspiration here.)

  1. The search type chip will let you pick what type of objects to search (currently only Communities and Users are supported, but now that this framework is place, others should be easy to add).
  2. The sort option has been taken off the text box and placed into a chip here as well.
  3. A feed type selector has also been added as the third chip.

In the future, filters by Community and Creator (like the web UI has) can be added as additional chips.

Issue Being Fixed

Issue Number: Related to #273

Screenshots / Recordings

qemu-system-x86_64_S5lplnN5Nh.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@micahmo
Copy link
Member Author

micahmo commented Oct 27, 2023

Updated this to follow the new refactor. Should be good to go!

@CTalvio
Copy link
Collaborator

CTalvio commented Oct 28, 2023

Damn buddy, you're still on fire! I'm catching up on what ya'll been doing.

I think I'd prefer the search options appear in a grid instead of being horizontally scrollable, and then having that grid be collapsed by default behind an "advanced search" button. I think there was some talk of this in matrix, as something like this will be necessary eventually due to the large number of possible options.

Can be another commit though, when I get back into swing I'll likely make a lot commits that are simple cosmetic/UX polish.

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Something to maybe consider in the future is splitting up the logic into smaller widgets (e.g., splitting up the search sort bar) but it's not necessary!

@hjiangsu hjiangsu merged commit 981ef88 into thunder-app:develop Oct 29, 2023
1 check passed
@micahmo micahmo deleted the feature/search-options branch October 29, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants