Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to address breaking Lemmy API changes #854

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

hjiangsu
Copy link
Member

Pull Request Description

This is a draft PR which fixes the breaking changes from the lemmy api as described here: thunder-app/lemmy_api_client#10

This is in draft stages right now as more testing is needed to ensure there's no breaking functionality still present. To briefly summarize the changes:

  • VoteType is no longer present in lemmy API and has been replaced by an int indicating the vote (-1, 0, 1)
  • Adjusted the classes/models to correspond with the new classes/models from the lemmy API refactor

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu
Copy link
Member Author

@micahmo I ran this and it seems like most things are functional at this stage (I just did a very brief look over things), so feel free to run this build and let me know if you spot anything!

Similar to the feed refactor, it'll be impractical to check for every single thing, so it might make some time for us to spot all the issues that were introduced as a result of this PR

@micahmo
Copy link
Member

micahmo commented Oct 26, 2023

From a quick test, things look good to me too! Agreed that the most practical approach is to get it in and start using it.

@hjiangsu
Copy link
Member Author

Sounds good! I'll go ahead and merge this PR in if that's all good with you

@micahmo
Copy link
Member

micahmo commented Oct 26, 2023

You bet!

@hjiangsu hjiangsu marked this pull request as ready for review October 26, 2023 19:53
@hjiangsu hjiangsu merged commit 8f1f3d8 into develop Oct 26, 2023
1 check passed
@micahmo micahmo deleted the refactor/lemmy-api branch October 27, 2023 02:44
@micahmo
Copy link
Member

micahmo commented Oct 27, 2023

@hjiangsu I just noticed one small "regression" after running this branch (maybe it was an intentional change?). The user profile area in the drawer no longer shows the instance name.

Before After
image image

@hjiangsu
Copy link
Member Author

Good catch! I think I may have commented that section out because the field no longer existed after the refactor. I'll take a look at it and find an alternative if possible!

@micahmo
Copy link
Member

micahmo commented Oct 27, 2023

Thanks! We still display the instance name in the account switcher, so I'm sure there's a way. 😊

@hjiangsu hjiangsu mentioned this pull request Oct 27, 2023
3 tasks
@hjiangsu
Copy link
Member Author

@micahmo I've added that logic back in #857!

@micahmo
Copy link
Member

micahmo commented Oct 27, 2023

Awesome, let me know when that one's ready to test/review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants