Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-organizing settings page and addition of post/comment previews #890

Merged
merged 12 commits into from
Nov 29, 2023

Conversation

hjiangsu
Copy link
Member

@hjiangsu hjiangsu commented Nov 13, 2023

Pull Request Description

This PR is two-fold. First, it introduces post and comment previews in the settings page. As part of this, I also took the time to reorganize some of the settings around to make it hopefully more intuitive.

Notes:

  • The previous Appearance page is moved into it's own page and renamed "Theming"
  • I've moved the appearance settings for posts and comments into new pages. To access appearance settings for posts/comments, you will need to navigate from Settings -> Appearance -> Posts and Settings -> Appearance -> Comments respectively
  • For the new post and comment pages, I've added an action which allows the user to reset that page's settings to their defaults
  • I've removed the "Score Counters" option from the general settings page as we are deprecating showing user scores on user sidebars (this is a restriction from lemmy starting in 0.19.x, not us)

Issue Being Fixed

Issue Number: #255

I've linked an related issue here, but the implementation differs from the original issue. I would like to get more feedback on the general feel of the changed settings so feel free to comment on any aspects here.

Screenshots / Recordings

settings.mp4
Comment Appearance Post Appearance
image image image

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@micahmo
Copy link
Member

micahmo commented Nov 22, 2023

Wow this looks awesome!!!

@hjiangsu hjiangsu marked this pull request as ready for review November 28, 2023 20:16
@hjiangsu
Copy link
Member Author

@micahmo This should now be ready to go - feel free to take it for a spin and let me know if you think any settings should be moved to a different section!

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! I really like the reorganization and the previews.

Tiny comments:

  • I liked that you replaced the ActionButtons for import/export with more standard looking settings items. I wonder if we should do the same for Apply under accessibility profiles and the Delete options under Debug.
  • We had talked about having an Advanced section, but with your reorg, I don't think any single page is too overwhelming, so I think we can put this off for now.

@micahmo
Copy link
Member

micahmo commented Nov 28, 2023

One more thing... the post preview isn't working for me. I'll see if it's something obvious!

qemu-system-x86_64_wBG3xuf5bb.mp4

@micahmo
Copy link
Member

micahmo commented Nov 28, 2023

Looks like it's because I'm not showing NFSW posts on the feed, so parsePostViews is filtering it out and returning an empty list. Hopefully an easy fix!

@hjiangsu
Copy link
Member Author

I wonder if we should do the same for Apply under accessibility profiles and the Delete options under Debug.

I'm not too sure how to apply the same style for accessibility profiles since it's not technically an option, but a confirmation of sorts. We can probably leave this as is for now!

For debug settings, I can definitely make it match better with the rest of the settings!

Looks like it's because I'm not showing NFSW posts on the feed, so parsePostViews is filtering it out and returning an empty list

Hmm, interesting, I'll take a look at this! It should still return some items as only one of them is marked as NSFW

@hjiangsu
Copy link
Member Author

Alright, I've made the changes to debug page and fixed the issues with the post previews not working. Let me know if it all looks good to you now!

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect now!

@hjiangsu hjiangsu merged commit 2e0d572 into develop Nov 29, 2023
1 check passed
@hjiangsu hjiangsu deleted the feature/refactor-settings branch November 29, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants