Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AppBar semantics #918

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Fix AppBar semantics #918

merged 1 commit into from
Nov 27, 2023

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Nov 27, 2023

Pull Request Description

This PR fixes a small issue with Semantics where a tap area in the post AppBar was being selected as an unlabeled element.

Issue Being Fixed

Issue Number: #915

Screenshots / Recordings

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

hjiangsu
hjiangsu approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 758ea1b into thunder-app:develop Nov 27, 2023
1 check passed
@micahmo micahmo deleted the fix/915-semantics branch November 27, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjiangsu hjiangsu hjiangsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@micahmo @hjiangsu