Add support for community and creator search filters #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjiangsu
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Looks good to me! I do wonder if there might be a better way UX-wise to show these two filters. Right now, it seems like you have to scroll in order to see the options which might cause users to not realize those options are available.
I do think that can be tackled at a later point in time, as this change allows us to be in parity with the web UI. Great work!
Agreed! We can get these two new options in using the same UI as the other options, then we can re-evaluate how best to show all of them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR adds support for community and creator filters in search. This should bring Thunder's search in parity with the web UI!
Issue Being Fixed
Issue Number: Not specifically called out in #273, but related.
Screenshots / Recordings
qemu-system-x86_64_KuxdWiMCwy.mp4
Checklist
semanticLabels where applicable for accessibility?