Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add semantic labels; fix spelling #931

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Add semantic labels; fix spelling #931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/l10n/app_en.arb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
},
"accessibility": "Accessibility",
"@accessibility": {},
"accessibilityProfilesDescription": "Accessibility profiles allows applying several settings at once to accomodate a particular accessibility requirement.",
"accessibilityProfilesDescription": "Accessibility profiles allows applying several settings at once to accommodate a particular accessibility requirement.",
"@accessibilityProfilesDescription": {},
"account": "Account",
"@account": {},
Expand Down Expand Up @@ -539,6 +539,14 @@
"@reset": {
"description": "Label for the reset button in Setting -> Appearance -> Posts/Comments"
},
"resetCommentPreferences": "Reset comment preferences",
"@resetCommentPreferences": {
"description": "Semantic label for button in comment appearance settings."
},
"resetPostPreferences": "Reset post preferences",
"@resetPostPreferences": {
"description": "Semantic label for button in post appearance settings."
},
"resetPreferences": "Reset Preferences",
"resetPreferencesAndData": "Reset Preferences and Data",
"@resetPreferencesAndData": {
Expand Down
5 changes: 4 additions & 1 deletion lib/settings/pages/comment_appearance_settings_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,10 @@ class _CommentAppearanceSettingsPageState extends State<CommentAppearanceSetting
pinned: true,
actions: [
IconButton(
icon: const Icon(Icons.restart_alt_rounded),
icon: Icon(
Icons.restart_alt_rounded,
semanticLabel: l10n.resetCommentPreferences,
),
onPressed: () {
showDialog(
context: context,
Expand Down
5 changes: 4 additions & 1 deletion lib/settings/pages/post_appearance_settings_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,10 @@ class _PostAppearanceSettingsPageState extends State<PostAppearanceSettingsPage>
pinned: true,
actions: [
IconButton(
icon: const Icon(Icons.restart_alt_rounded),
icon: Icon(
Icons.restart_alt_rounded,
semanticLabel: l10n.resetPostPreferences,
),
onPressed: () {
showDialog(
context: context,
Expand Down
Loading