Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error message for language_not_allowed #933

Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Nov 30, 2023

Pull Request Description

This PR just adds a nice error message for the language_not_allowed Lemmy exception, which I ran into in #922.

Issue Being Fixed

Issue Number: Related to #922

Screenshots / Recordings

qemu-system-x86_64_FZPnSXIn34.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu
Copy link
Member

Is it possible to extend the snackbar duration a bit longer? I feel like it might be too short for the length of that message! Or alternatively, we could make the error message shorter as well

@micahmo
Copy link
Member Author

micahmo commented Nov 30, 2023

Is it possible to extend the snackbar duration a bit longer?

Sure! What do you think about having the duration be a function of how long the message is (with a reasonable minimum)?

qemu-system-x86_64_D58HRLB82T.mp4

@hjiangsu
Copy link
Member

I think thats a clever way to do it!

@hjiangsu hjiangsu merged commit 904a58b into thunder-app:develop Nov 30, 2023
1 check passed
@micahmo micahmo deleted the feature/add-language-error-message branch November 30, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants