Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added spinning indicator when creating or editing posts #934

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Added spinning indicator when creating or editing posts #934

merged 1 commit into from
Nov 30, 2023

Conversation

hjiangsu
Copy link
Member

Pull Request Description

This PR adds back the spinning indicator when creating or editing posts. I added a new status to CreatePostCubit to help with this.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

259a0f14-a52b-4f8d-93b5-07c1441d8744.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

micahmo
micahmo approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit d1baf6b into develop Nov 30, 2023
1 check passed
@hjiangsu hjiangsu deleted the fix/create-post-loading-indicator branch November 30, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahmo micahmo micahmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hjiangsu @micahmo