Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to show/hide post and comment scores; Ability to show/hide bot content #936

Merged
merged 5 commits into from
Dec 4, 2023

Conversation

hjiangsu
Copy link
Member

@hjiangsu hjiangsu commented Nov 30, 2023

Pull Request Description

Review with whitespace off

This PR add a couple more options which are synced to a Lemmy account - notably

  • The ability to show/hide post and comment scores. This includes hiding scores from the feed and post pages.
  • The ability to show/hide bot content including posts and comments

This PR also adds a few more options to ToggleOption to allow for custom icon sizes and spacing.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

36a2cf19-07d9-4e92-8bdc-3fd6babaaa25.mp4
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2023-11-30.at.15.09.36.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM!

I had one UI question about hiding scores. When looking at comments, there are no arrows until the user upvotes/downvotes. However, in the feed, there is always an upward error on every post, which gets colored when the user votes. Maybe the arrow should be hidden in the feed too?

@hjiangsu
Copy link
Member Author

hjiangsu commented Dec 3, 2023

However, in the feed, there is always an upward error on every post, which gets colored when the user votes. Maybe the arrow should be hidden in the feed too?

I was debating on how the UI should look like here too. The main reason I opted for showing it on the feed is to keep the posts uniform. I think it makes it easier to scan through the feed when the arrow is there as opposed to only being there sometimes.

For the comments, I kept it hidden because there's much less info to scan through in the header (just the user's username) as opposed to the post cards on feed (vote, # of comments, timestamp, url). Let me know what you think though!

@micahmo
Copy link
Member

micahmo commented Dec 3, 2023

Let me know what you think though!

I don't have a strong opinion! My only thought was about consistency, and maybe that people would think they had upvoted posts. But you also make a good point about how this fits into the existing amount of info.

@hjiangsu
Copy link
Member Author

hjiangsu commented Dec 4, 2023

Maybe we'll roll with this first and get user feedback. I'm not well versed in UI/UX so I'm not sure about the best approach here 😅

@hjiangsu hjiangsu merged commit 84ac4bf into develop Dec 4, 2023
1 check passed
@hjiangsu hjiangsu deleted the feature/setting-hide-score-and-bots branch December 4, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants