Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for issues with feed loading on initial app start #940

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

hjiangsu
Copy link
Member

@hjiangsu hjiangsu commented Dec 1, 2023

Pull Request Description

This PR hopefully fixes the issue where the feed does not load when first starting the app. The main change here was to reduce potential extraneous API calls to the instance when Thunder initially starts up.

I don't think there are any side-effects that are caused by these changes, but will have to keep an eye out for any further problems. (Tested switching between anonymous and logged in accounts)

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu
Copy link
Member Author

hjiangsu commented Dec 1, 2023

@micahmo Once this is merged in, I'll deploy a second pre-release version to get this change out as quickly as possible as this issue might be affecting a lot of users on varying instances!

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Agreed on getting this out quickly.

@hjiangsu hjiangsu merged commit a6d88f2 into develop Dec 1, 2023
1 check passed
@hjiangsu hjiangsu deleted the fix/initial-feed-loading branch December 1, 2023 22:50
@micahmo
Copy link
Member

micahmo commented Dec 2, 2023

@hjiangsu It looks like I can no longer open a community from the post card metadata. I'm running release at the moment and not near my PC so I don't have any more details. Can you repro?

screen-20231202-113851.mp4

@hjiangsu
Copy link
Member Author

hjiangsu commented Dec 2, 2023

Found it and creating a PR for it now! Thanks for letting me know

@hjiangsu
Copy link
Member Author

hjiangsu commented Dec 2, 2023

@micahmo Just released a patch for this issue on 0.2.7-3

@micahmo
Copy link
Member

micahmo commented Dec 3, 2023

That was fast, thanks! Works now! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants