Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added throttling to CheckAuth method to reduce API calls #947

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

hjiangsu
Copy link
Member

@hjiangsu hjiangsu commented Dec 4, 2023

Pull Request Description

This PR adds throttling to CheckAuth event to reduce API calls when Thunder first starts up. It seems like one of the causes of the 503 errors have to do with CheckAuth calling GetSite many times when the app starts up. This should prevent extraneous calls and eliminate the 503 errors.

This only seems to occur when logged in to an account on some instances (aussie.zone, and perhaps others)

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, LGTM!

@hjiangsu hjiangsu merged commit 235b368 into develop Dec 4, 2023
1 check passed
@hjiangsu hjiangsu deleted the fix/throttle-auth branch December 4, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants