Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored FAB settings page #949

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Refactored FAB settings page #949

merged 1 commit into from
Dec 5, 2023

Conversation

hjiangsu
Copy link
Member

@hjiangsu hjiangsu commented Dec 5, 2023

Pull Request Description

Review with whitespace off

This PR refactors the FAB settings page to follow similar conventions of the other recently refactored setting pages. Main changes include:

  • Changed to using slivers instead of previous SingleChildScrollView
  • Updated all text to use localized text when available. Almost all the text should already have localized versions (except a few labels, and the information section)
  • Refactored the information section to use markdown instead of multiple text widgets
  • Added expand/collapse icon to information page

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

original refactored
simulator_screenshot_CE67E578-57A9-4591-8F2E-0B8BB2CCFAAE simulator_screenshot_F6698CC2-DE5E-4E7E-B9D8-83A18688B484

When switching to a different language with the refactor:

spanish norwegian
simulator_screenshot_F9C05B16-B1C6-4A2A-A600-C333899EB760 simulator_screenshot_692298C0-C0B5-4852-9009-EC09CFF79005

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Nice housekeeping stuff. And good idea to use markdown for the body of text.

@hjiangsu hjiangsu merged commit 8551545 into develop Dec 5, 2023
1 check passed
@hjiangsu hjiangsu deleted the refactor/fab-settings branch December 5, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants