Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve URL detection for search #959

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Dec 6, 2023

Pull Request Description

This is a small PR which handles a workflow I've been using lately. Currently, if the search type is Posts and the user enters a valid URL, we will automatically switch the search sub-type to URL. However, if the text is already entered and then the user changes the search type to Posts, we don't make the same detection. This PR changes that, so we do. Just a small improvement to make searching easier!

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

qemu-system-x86_64_hdbuUajad6.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 8274a5e into thunder-app:develop Dec 6, 2023
1 check passed
@micahmo micahmo deleted the feature/detect-url-search branch December 6, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants