Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show version on instance page #964

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Dec 6, 2023

Pull Request Description

This PR adds the version of the instance to the heading on the instance page.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

image
image

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu
Copy link
Member

hjiangsu commented Dec 6, 2023

Nice! I was also thinking of adding this information somewhere - I wonder if we could also add in the instance version in the account selector bottom sheet (if its not too much work)? I was thinking maybe in between the instance name and the ping time

@micahmo
Copy link
Member Author

micahmo commented Dec 6, 2023

I wonder if we could also add in the instance version in the account selector bottom sheet

Funny you say that, I actually tried that first! On my emulator (with an admittedly low DPI), there is often a little bit too much info to display horizontally.

image

But on a physical device it's probably fine. I can just make sure the data is properly truncated, and maybe put the whole thing in a tooltip. What do you think?

@hjiangsu
Copy link
Member

hjiangsu commented Dec 6, 2023

But on a physical device it's probably fine. I can just make sure the data is properly truncated, and maybe put the whole thing in a tooltip.

I think it should be fine on a physical device as you said! But I agree with truncating the data if possible and adding a tooltip for it. I personally prefer the instance being to the left of the ping time since that'll be useful information for any instance-based issues, but I'll let you make the final call on where its placed!

@micahmo
Copy link
Member Author

micahmo commented Dec 6, 2023

I personally prefer the instance being to the left of the ping time

Agreed!

I agree with truncating the data if possible

Since truncating is a bit tricky (multiple widgets, no way to know which one needs to be truncated), what do you think about a Wrap? Again, this should only be an issue on low DPI devices.

image

@hjiangsu
Copy link
Member

hjiangsu commented Dec 6, 2023

what do you think about a Wrap?

I think that works! It's always tricky to work with low DPI or large text scaling, but at least we'll be able to show all information on the page. It would be nice if there was a guide for how to handle UI for these cases 😅

@micahmo
Copy link
Member Author

micahmo commented Dec 6, 2023

Alright, just pushed these changes! Review without whitespace. 😊

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit fd74850 into thunder-app:develop Dec 6, 2023
1 check passed
@micahmo micahmo deleted the feature/instance-version branch December 7, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants