-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show version on instance page #964
Show version on instance page #964
Conversation
Nice! I was also thinking of adding this information somewhere - I wonder if we could also add in the instance version in the account selector bottom sheet (if its not too much work)? I was thinking maybe in between the instance name and the ping time |
I think it should be fine on a physical device as you said! But I agree with truncating the data if possible and adding a tooltip for it. I personally prefer the instance being to the left of the ping time since that'll be useful information for any instance-based issues, but I'll let you make the final call on where its placed! |
Agreed!
Since truncating is a bit tricky (multiple widgets, no way to know which one needs to be truncated), what do you think about a |
I think that works! It's always tricky to work with low DPI or large text scaling, but at least we'll be able to show all information on the page. It would be nice if there was a guide for how to handle UI for these cases 😅 |
Alright, just pushed these changes! Review without whitespace. 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Pull Request Description
This PR adds the version of the instance to the heading on the instance page.
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Checklist
semanticLabel
s where applicable for accessibility?