Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: CMake build fixes + Uikit moc header fix #795

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

bedwardly-down
Copy link
Contributor

@bedwardly-down bedwardly-down commented Jul 14, 2024

Instead of putting all of my efforts into ccache right now, I went back to the basics and discovered the root of the Uikit issue: the moc headers list was out of order, causing the failure. This will replace #793

@bedwardly-down
Copy link
Contributor Author

This uses a hard coded checkout of my fork and the branch where the code changes were made just to show that it builds properly. If these changes get approved, I'll push a commit that removes that part. There will most likely be a failure to build when I do that but merging the changes into master should fix that.

@eprikazchikov eprikazchikov merged commit 813ec22 into thunder-engine:master Jul 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants