Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3102123 by chr.fritsch: Add missing modules in update dependencies #129

Merged
merged 1 commit into from Dec 19, 2019

Conversation

chrfritsch
Copy link
Member

Make sure these boxes are checked before submitting your pull request - thank you!

  • All coding styles are fulfilled. (How to check for cs issues?)
  • All tests are running locally. (How to run the test?)
  • Necessary update hooks are provided.
  • User roles have correct access for new introduced permission.
  • Every thunder module has a README.md in its root. Follow this guidelines, but we don't need every topic.
  • Code is covered with well-balanced amount of inline comments.

If you are really awesome, then your feature is covered by additional tests. Well done!

@chrfritsch chrfritsch changed the title Add missing modules in update dependencies Issue #3102123 by chr.fritsch: Add missing modules in update dependencies Dec 19, 2019
@chrfritsch chrfritsch merged commit fc345d1 into 8.x-4.x Dec 19, 2019
@chrfritsch chrfritsch deleted the fix/update-dependencies_t3.4 branch December 19, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants