New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #3057506: Fix coding style issues #18

Merged

dbosen merged 1 commit into 8.x-3.x from fix/3057506-cs-issues

May 28, 2019

Member

chrfritsch commented May 28, 2019

Make sure these boxes are checked before submitting your pull request - thank you!

All coding styles are fulfilled. (How to check for cs issues?)
All tests are running locally. (How to run the test?)
Necessary update hooks are provided.
User roles have correct access for new introduced permission.
Every thunder module has a README.md in its root. Follow this guidelines, but we don't need every topic.
Code is covered with well-balanced amount of inline comments.

If you are really awesome, then your feature is covered by additional tests. Well done!


          Issue #3057506: Fix coding style issues

406322b

dbosen approved these changes

View reviewed changes

dbosen merged commit 1510446 into 8.x-3.x

dbosen deleted the fix/3057506-cs-issues branch

May 28, 2019 10:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment