Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #3128263: Move thunder_amp theme to d.o. #197

Merged
merged 6 commits into from Apr 16, 2020
Merged

Issue #3128263: Move thunder_amp theme to d.o. #197

merged 6 commits into from Apr 16, 2020

Conversation

chrfritsch
Copy link
Member

@chrfritsch chrfritsch commented Apr 9, 2020 •
edited

Make sure these boxes are checked before submitting your pull request - thank you!

  • All coding styles are fulfilled. (How to check for cs issues?)
  • All tests are running locally. (How to run the test?)
  • Necessary update hooks are provided.
  • User roles have correct access for new introduced permission.
  • Every thunder module has a README.md in its root. Follow this guidelines, but we don't need every topic.
  • Code is covered with well-balanced amount of inline comments.

If you are really awesome, then your feature is covered by additional tests. Well done!

@ol0lll ol0lll temporarily deployed to thunder-dist-task-move--husmzs April 9, 2020 10:39 Inactive
@ol0lll ol0lll temporarily deployed to thunder-dist-task-move--husmzs April 9, 2020 10:41 Inactive
@ol0lll ol0lll temporarily deployed to thunder-dist-task-move--husmzs April 9, 2020 10:52 Inactive
@chrfritsch chrfritsch marked this pull request as ready for review April 9, 2020 11:12
@ol0lll ol0lll temporarily deployed to thunder-dist-task-move--husmzs April 9, 2020 11:18 Inactive
@ol0lll ol0lll temporarily deployed to thunder-dist-task-move--husmzs April 9, 2020 11:28 Inactive
@ol0lll ol0lll temporarily deployed to thunder-dist-task-move--husmzs April 9, 2020 11:34 Inactive
@ol0lll ol0lll temporarily deployed to thunder-dist-task-move--husmzs April 9, 2020 11:54 Inactive
@chrfritsch
feat: move AMP into its own theme
3b2d82b 
refactor: remove conflict

build: use tag

[TEST_EVERYTHING]

[TEST_EVERYTHING]
@chrfritsch chrfritsch added the test-min Triggers the minimum requirements testing label Apr 16, 2020
@chrfritsch chrfritsch changed the title feat: move AMP into its own theme Issue #3128263: Move thunder_amp theme to d.o. Apr 16, 2020
dbosen
dbosen approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@dbosen dbosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chrfritsch chrfritsch merged commit 51a8ea4 into 8.x-4.x Apr 16, 2020
@chrfritsch chrfritsch deleted the task/move-amp branch April 16, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbosen dbosen dbosen approved these changes

Assignees
No one assigned
Labels
test-min Triggers the minimum requirements testing
Projects
None yet
Milestone
No milestone
3 participants
@chrfritsch @dbosen @ol0lll