Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #3168898: Release Thunder 6.0.2 #301

Merged
merged 1 commit into from Sep 3, 2020
Merged

Issue #3168898: Release Thunder 6.0.2 #301

merged 1 commit into from Sep 3, 2020

Conversation

dbosen
Copy link
Member

@dbosen dbosen commented Sep 3, 2020

Make sure these boxes are checked before submitting your pull request - thank you!

  • All coding styles are fulfilled. (How to check for cs issues?)
  • All tests are running locally. (How to run the test?)
  • Necessary update hooks are provided.
  • User roles have correct access for new introduced permission.
  • Every thunder module has a README.md in its root. Follow this guidelines, but we don't need every topic.
  • Code is covered with well-balanced amount of inline comments.

If you are really awesome, then your feature is covered by additional tests. Well done!

@ol0lll ol0lll temporarily deployed to thunder-dist-release-6--yntfqt September 3, 2020 11:13 Inactive
chrfritsch
chrfritsch approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@chrfritsch chrfritsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good👍

@dbosen dbosen merged commit 5a37673 into 6.0.x Sep 3, 2020
@dbosen dbosen deleted the release/6.0.2 branch September 3, 2020 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrfritsch chrfritsch chrfritsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@dbosen @chrfritsch @ol0lll