Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #3200971 by chr.fritsch, daniel.bosen: Set the media name by default to the image filename in dropzone upload widget #354

Merged
merged 6 commits into from Mar 1, 2021
Merged

Issue #3200971 by chr.fritsch, daniel.bosen: Set the media name by default to the image filename in dropzone upload widget #354

merged 6 commits into from Mar 1, 2021

Conversation

chrfritsch
Copy link
Member

Make sure these boxes are checked before submitting your pull request - thank you!

  • All coding styles are fulfilled. (How to check for cs issues?)
  • All tests are running locally. (How to run the test?)
  • Necessary update hooks are provided.
  • User roles have correct access for new introduced permission.
  • Every thunder module has a README.md in its root. Follow this guidelines, but we don't need every topic.
  • Code is covered with well-balanced amount of inline comments.

If you are really awesome, then your feature is covered by additional tests. Well done!

@ol0lll ol0lll temporarily deployed to thunder-pr-354 December 16, 2020 15:40 Inactive
chrfritsch
chrfritsch commented Dec 16, 2020
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@chrfritsch chrfritsch added test-min Triggers the minimum requirements testing test-upgrade Triggers the upgrade path testing labels Mar 1, 2021
dbosen
dbosen approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@dbosen dbosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chrfritsch chrfritsch changed the title fix: image name is filename by default Issue #3200971 by chr.fritsch, daniel.bosen: Set the media name by default to the image filename in dropzone upload widget Mar 1, 2021
@chrfritsch chrfritsch merged commit 3c3030b into 6.1.x Mar 1, 2021
@chrfritsch chrfritsch deleted the fix/image-name-default branch March 1, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbosen dbosen dbosen approved these changes

Assignees
No one assigned
Labels
test-min Triggers the minimum requirements testing test-upgrade Triggers the upgrade path testing
Projects
None yet
Milestone
No milestone
3 participants
@chrfritsch @dbosen @ol0lll