Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sitemap variants and variant index #404

Merged
merged 21 commits into from Jul 6, 2021
Merged

Conversation

dbosen
Copy link
Member

@dbosen dbosen commented Jun 30, 2021

Make sure these boxes are checked before submitting your pull request - thank you!

  • All coding styles are fulfilled. (How to check for cs issues?)
  • All tests are running locally. (How to run the test?)
  • Necessary update hooks are provided.
  • User roles have correct access for new introduced permission.
  • Every thunder module has a README.md in its root. Follow this guidelines, but we don't need every topic.
  • Code is covered with well-balanced amount of inline comments.

If you are really awesome, then your feature is covered by additional tests. Well done!

@dbosen dbosen added test-min Triggers the minimum requirements testing test-upgrade Triggers the upgrade path testing labels Jun 30, 2021
@ol0lll ol0lll temporarily deployed to thunder-pr-404 June 30, 2021 13:41 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-404 June 30, 2021 13:52 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-404 July 1, 2021 07:51 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-404 July 1, 2021 11:21 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-404 July 1, 2021 12:39 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-404 July 1, 2021 12:40 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-404 July 5, 2021 10:02 Inactive
@dbosen dbosen removed the test-min Triggers the minimum requirements testing label Jul 5, 2021
@ol0lll ol0lll temporarily deployed to thunder-pr-404 July 5, 2021 12:02 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-404 July 5, 2021 12:03 Inactive
@dbosen dbosen added the test-min Triggers the minimum requirements testing label Jul 5, 2021
@ol0lll ol0lll temporarily deployed to thunder-pr-404 July 5, 2021 13:23 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-404 July 5, 2021 15:37 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-404 July 6, 2021 06:10 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-404 July 6, 2021 06:11 Inactive
Copy link
Member

@ol0lll ol0lll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@dbosen dbosen merged commit 023696a into 6.2.x Jul 6, 2021
@dbosen dbosen deleted the feature/simple_sitemap_index branch July 6, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-min Triggers the minimum requirements testing test-upgrade Triggers the upgrade path testing
Projects
None yet
2 participants