Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phpstan errors #606

Merged
merged 2 commits into from
Nov 8, 2022
Merged

Fix phpstan errors #606

merged 2 commits into from
Nov 8, 2022

Conversation

ol0lll
Copy link
Member

@ol0lll ol0lll commented Nov 4, 2022

Make sure these boxes are checked before submitting your pull request - thank you!

  • All coding styles are fulfilled. (How to check for cs issues?)
  • All tests are running locally. (How to run the test?)
  • Necessary update hooks are provided.
  • User roles have correct access for new introduced permission.
  • Every thunder module has a README.md in its root. Follow this guidelines, but we don't need every topic.
  • Code is covered with well-balanced amount of inline comments.
  • New features or changes are documented.

If you are really awesome, then your feature is covered by additional tests. Well done!

@ol0lll ol0lll temporarily deployed to thunder-pr-606 November 4, 2022 13:55 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-606 November 8, 2022 13:00 Inactive
@chrfritsch chrfritsch merged commit ec658cb into 6.4.x Nov 8, 2022
@chrfritsch chrfritsch deleted the fix/phpstan-errors branch November 8, 2022 13:26
chrfritsch pushed a commit that referenced this pull request Nov 8, 2022
chrfritsch pushed a commit that referenced this pull request Nov 14, 2022
* 6.4.x:
  Remove test-performance action
  Remove password policy patch, update diff module and increase selenium version
  fix/instagram-graphql-type (#605)
  Fix phpstan errors (#606)
  Fix export of GraphQL extensions
chrfritsch pushed a commit that referenced this pull request Nov 14, 2022
* Fix phpstan errors

* Actually return an int

Co-authored-by: Alex Pott <alex.a.pott@googlemail.com>
dbosen added a commit that referenced this pull request Nov 14, 2022
* Fix export of GraphQL extensions

* Fix phpstan errors (#606)

* Fix phpstan errors

* Actually return an int

Co-authored-by: Alex Pott <alex.a.pott@googlemail.com>

* fix/instagram-graphql-type (#605)

Co-authored-by: Christian Fritsch <christian.fritsch@burda.com>

* Remove password policy patch, update diff module and increase selenium version

* remove password policy patch

* article

* revert

* selenium version

* new diff version

* update entity browser

* selenium 105

* remove diff patch

* do not update entity browser

* Remove test-performance action

Co-authored-by: Christian Fritsch <christian.fritsch@burda.com>

* Remove gin patch

Co-authored-by: Daniel Bosen <daniel.bosen@burda.com>
Co-authored-by: Volker Killesreiter <killesre@gmail.com>
Co-authored-by: Alex Pott <alex.a.pott@googlemail.com>
Co-authored-by: Christian Fritsch <christian.fritsch@burda.com>
chrfritsch pushed a commit that referenced this pull request Nov 21, 2022
* 6.4.x:
  Update field_group module (#613)
  Issue #3319701 by alexpott, daniel.bosen: Add Media File Delete integration and new permission to delete any file
  Remove test-performance action
  Remove password policy patch, update diff module and increase selenium version
  fix/instagram-graphql-type (#605)
  Fix phpstan errors (#606)
  Fix export of GraphQL extensions
chrfritsch pushed a commit that referenced this pull request Nov 21, 2022
* morpho:
  Fix test
  Fix
  Update field_group module (#613)
  Issue #3319701 by alexpott, daniel.bosen: Add Media File Delete integration and new permission to delete any file
  Remove test-performance action
  Remove password policy patch, update diff module and increase selenium version
  fix/instagram-graphql-type (#605)
  Fix phpstan errors (#606)
  Fix export of GraphQL extensions
chrfritsch pushed a commit that referenced this pull request Nov 23, 2022
* morpho: (37 commits)
  Enable gin modern sidebar (#603)
  Fix test
  Fix
  Update field_group module (#613)
  Update simple_sitemap module (#612)
  Issue #3319701 by alexpott, daniel.bosen: Add Media File Delete integration and new permission to delete any file
  Update morpho
  Remove test-performance action
  Remove password policy patch, update diff module and increase selenium version
  fix/instagram-graphql-type (#605)
  Fix phpstan errors (#606)
  Fix export of GraphQL extensions
  Fix phpstan baseline
  Merge 6.4.x changes back into morpho
  Issue #3311213 by daniel.bosen, chr.fritsch: Release Thunder 6.4.3
  Add ParagraphBehavior GraphQL data producer
  Bump vite from 2.7.10 to 2.9.15 (#595)
  Increase default content version (#598)
  Issue #3305898 by daniel.bosen, chr.fritsch: Release Thunder 6.4.2
  Improve graphql embed
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants