Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(thunder_xymatic): add default and paragraph_preview entity view … #704

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

chrfritsch
Copy link
Member

…displays for media.xymatic bundle

feat(thunder_xymatic): add media.xymatic.thumbnail view display configuration file

Make sure these boxes are checked before submitting your pull request - thank you!

  • All coding styles are fulfilled. (How to check for cs issues?)
  • All tests are running locally. (How to run the test?)
  • Necessary update hooks are provided.
  • User roles have correct access for new introduced permission.
  • Every thunder module has a README.md in its root. Follow this guidelines, but we don't need every topic.
  • Code is covered with well-balanced amount of inline comments.
  • New features or changes are documented.

If you are really awesome, then your feature is covered by additional tests. Well done!

…displays for media.xymatic bundle

feat(thunder_xymatic): add media.xymatic.thumbnail view display configuration file
@ol0lll ol0lll temporarily deployed to thunder-pr-704 April 25, 2023 13:53 Inactive
@IT-Cru
Copy link
Contributor

IT-Cru commented Apr 25, 2023

LGTM

I think at some point default view mode should be switched to Xymatic Player field formatter, when this is ready in Xymatic contrib module on d.o

Config for Thunder 7 could be maybe have different requirements for new Gin admin theme layouts.

@chrfritsch chrfritsch merged commit d024ad4 into 6.5.x Apr 26, 2023
@chrfritsch chrfritsch deleted the xymatic-view-displays branch April 26, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants