Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thunder rout entity data provider #707

Draft
wants to merge 7 commits into
base: 6.5.x
Choose a base branch
from
Draft

Conversation

dbosen
Copy link
Member

@dbosen dbosen commented May 4, 2023

Make sure these boxes are checked before submitting your pull request - thank you!

  • All coding styles are fulfilled. (How to check for cs issues?)
  • All tests are running locally. (How to run the test?)
  • Necessary update hooks are provided.
  • User roles have correct access for new introduced permission.
  • Every thunder module has a README.md in its root. Follow this guidelines, but we don't need every topic.
  • Code is covered with well-balanced amount of inline comments.
  • New features or changes are documented.

If you are really awesome, then your feature is covered by additional tests. Well done!

@ol0lll ol0lll temporarily deployed to thunder-pr-707 May 4, 2023 05:24 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-707 May 4, 2023 06:13 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-707 May 4, 2023 09:43 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-707 May 4, 2023 13:35 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-707 May 4, 2023 15:09 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-707 May 4, 2023 15:35 Inactive
If /example-page is Node 6 in Drupal, the following variables are valid:

Get the current revision, which is the default query to the currently published page.
```json
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[markdownlint] reported by reviewdog 🐶
MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: "```json"]

```

Get a specific revision, can be an old revision, or a not yet published draft
```json
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[markdownlint] reported by reviewdog 🐶
MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: "```json"]

```

Get the latest revision, which might be an unpublished draft. The latest revision might not be available for a given node.
```json
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[markdownlint] reported by reviewdog 🐶
MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: "```json"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants