-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request (and offer) update UI to a more modern look #967
Comments
Sure! It's actually "fairly" simple to contribute to the UI.
I'm definitely open to suggestions / pull requests! But if you're committed about fixing this, I think it's better to iterate on mockups first, before moving on to the actual hacking on the code? Cheers, Jonathan |
Potentially related to this: when updating to Tb38 on Windows today, I noticed that everything has gotten very, very white. Apparently, the |
Er, |
The earlier blue background/gray header was really much better. Would it be possible to add something like a theme option from the plugin options? P.S. Thanks a lot for this amazing plugin. |
In the meantime, I "fixed" it with a Stylish extension: @media all and (-moz-windows-default-theme) {
browser#multimessage {
background-color: rgb(248, 248, 248) !important;
}
@-moz-document url(chrome://conversations/content/stub.xhtml) {
body { background-color: rgb(248, 248, 248) !important; }
div#conversationHeaderWrapper > div#conversationHeader {
background-color: #dddde0 !important;
}
}
} |
Hi Blerner, would really appreciate if you could guide on where and how to put this code in. I am pretty sure a lot of people would want to use this. Thanks in advance. |
Ben, do you know any special moz-specific CSS color that would look good both on Windows and Linux? Otherwise, I'm up for a pull request with a @media -moz-windows-default-theme in it. |
Not offhand, no. I had tried using a moz- color, but couldn't find one that worked, so I dug back through older versions of mxr's history to find that rgb(248,248,248) color above. |
Did you try these in addition to the moz colors? |
I think I'd tried a couple of them, and I think they all wound up rendering as pure white, so I gave up looking for the "right" solution and switched to looking for a working "solution" :) |
I think that'll be alright. Remember that you can play with the opacity: CSS property (e.g. on the On 7/11/2015 12:38 AM, Chris Lajoie wrote:
|
I'm not sure how it used to look, so I don't know what look you're going for. If I could see what it is "supposed" to look like I could try to get it as close as possible to that using the standard named colors like menu, window, etc. |
@protz, do you have an old version of the plugin? |
Sure. Older versions are at https://addons.mozilla.org/en-US/developers/addon/gmail-conversation-view/versions ; the previous one (2.8.1) needs Thunderbird 31 to run, though. Thanks! |
So here is what it looked like in 2.8.1. And now I'm confused as to what exactly people are complaining about. The current version looks virtually identical (without my modification that made the In any case I think the gray looks better and it makes it easier to tell where the list ends and the preview pane begins.. If you agree I'll go ahead and submit a pull request with that modification. As to the OP's suggestion that the UI is "outdated", I don't see any merit in that. As long as everything is readable and conforms to system themes, I think that's all you could ever want. IMHO of course. |
It's not GConv that changed -- it's Thunderbird. Try running the same extension in Tb37 and Tb38, and the colors should be different. (In particular, the subject line where the buttons are should be the same background gray.) That's why I specifically mentioned the Tb versions ;-) The menu color you found looks about right to me... |
I see, thanks Ben. I'll go ahead and put in a PR for the gray |
@elioqoshi Hey there! What is the current status of this? The default theme recently broke again on Linux-trunk (due to Gtk3 builds). Now would be a great time to look into the refresh :) Cheers, Jonathan Ps: if the generated HTML is hard to theme / modify, I can also tweak the HTML generation so that it's easier to make it look good |
+1 If you need help ping me. I really like the way postbox visualized conversations. It's pretty simple and modern. |
@protz Oh dear, I'm a GitHub noob and completely forgot about this in the Notifications (designer problems) Currently working on some mockups for the UI using Material Design from Google, will keep you updated. |
Just a quick reply as I'm at work, but if it's just about a re-design of the app, I'm all in favor of integrating! I think forking would be a very bad idea, and you probably want to benefit from the 100,000+ user-base of Conversations. Let me review this more closely once I'm back home. Is there anywhere I can look at your current patch? |
Again, I'm not a developer so I don't know what's best in terms of software development. I just think that the addon deserves more attention by having a better UI/UX and eventually a smarter name/branding than Gmail Conversation view. Basically it's all about the redesign of the UI and I personally would think the addon could benefit from a new name. What do you think? |
The name is actually Thunderbird Conversations (see https://addons.mozilla.org/en-US/thunderbird/addon/gmail-conversation-view/). "gmail-conversation-view" is the old name that still hangs around in some URLs. I thought you had already started writing some CSS. I think the mockups look good, and I'd be happy to help you integrate them (via pull requests) once you start the coding phase! |
Personally -- I think using Material Design on any platform that isn't a recent Android is as out-of-place as using Windows Metro on OS X, or Gtk+ on Windows. The point is to feel native and integrated into the host environment, not to force another model of UI design. That said -- I rather like the screenshots above :) I prefer the first one, with multiple colors for multiple authors, but I'm not a huge fan of solidly-colored flat icons (they feel a bit out of place to me). I'm also not sure what they mean: in the conversation header, from right to left I see "delete, archive, no, chat, find a mailman, and crop a picture"... ;-) What will the UI look like to indicate "there are unread messages in this thread"? Currently, it's a blue star in the button, but here every icon is already blue... What I'd really like to see in a refresh of this addon is something motivated by an incredibly long (and ongoing) email thread -- the "accordion" view in Gmail that hides even the message headers of anything but the first and last messages in a thread, and hopefully with it the ability to make TBConv even lazier about loading and rendering messages, so that accessing the newest email in a thread won't immediately hang TB for a few seconds while all 100+ messages are rendered. (The behavior in Gmail is that once you click on the accordion it expands to all the collapsed headers, and once you click on a header it expands that message.) |
So, I did some quick experiments (see https://github.com/xi/GMail-Conversation-View/tree/feature-ui). I found a major issue with the design approach taken by @elioqoshi: Material design and flat design in general uses few borders and instead depends on color contrast completely. However, since we are using system colors, we do not have control over these colors I found that with my theme the contrast is insufficient and the UI gets really messy. I am not sure how to go on. I will see if I can cherry-pick some details from the mockups. Apart from that I will wait for feedback. |
Excellent! Any screenshots?
…On 1/5/17 11:08 PM, Tobias Bengfort wrote:
So, I did some quick experiments (see
https://github.com/xi/GMail-Conversation-View/tree/feature-ui). I
found a major issue with the design approach taken by @elioqoshi
<https://github.com/elioqoshi>:
Material design and flat design in general uses few borders and
instead depends on color contrast completely. However, since we are
using system colors, we do not have control over these colors I found
that with my theme the contrast is insufficient and the UI gets really
messy.
I am not sure how to go on. I will see if I can cherry-pick some
details from the mockups. Apart from that I will wait for feedback.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#967 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANGs5BlDe7p1APKoIQDVHJi71c07mfKks5rPXfrgaJpZM4E7WEf>.
|
Had this on the radar for the last few months and actually tonight i wanted to give it a try. Seems @xi beat me to it by mere hours 😄 Message detailsActions menuContact popup |
Getting there! Small but helpful steps! Let me know if I can help with anything. Do you need the source files? I have done them in Adobe Illustrator. ping @AleksanderKoko to chime in as well |
Hi @elioqoshi, nice that you are still interested! There are some things you could do! Most important would be to figure out how your mocks relate to thunderbird themes, i.e. which colors should we use? (see https://developer.mozilla.org/en-US/docs/Web/CSS/color_value#System_Colors for a list of available colors) And then there is the issue that nobody seems to have enough time to implement a whole design on their own, so it could be helpful to split this into several tasks. This gets easier if you can provide some background information:
I think I cannot open illustrator files. But a color scheme (for the non-system colors) and individual components would be a great addition to the comps you already provided. |
Hi @elioqoshi . Thanks for the ping. Saw a draft of design a couple of days ago and I have some time on my open source hours calendar to work with something useful and cool. Have to read this thread, really long. |
@fllp if it is not too much of a hassle it would be great if you could just upload it here. |
Sure, i'll post them as soon as i can. |
Here is a screenshot of the current state, including #1142: Next steps:
Also, there is still the question of what to do with borders (see #967 (comment)). |
Its getting there!
Not suggesting that. Material Design Colors aren't designed for that. We can find a compromise however. Also, your current theme settings are pretty inconsistent with Material Design, so not sure how good it would be to base changes on that. |
I don't really understand what you are saying. This plugin uses theme colors for all the chrome, not material design colors. Are you suggesting to change that? I am strongly in favor of using theme colors. Consistency across applications for me as a user is hugely important. So if we stick to theme colors we have to ensure that colors work with both light and dark themes. |
Sorry, I don't really follow you here. Might be a bit difficult for me via written text. @jancborchardt might have an idea for colors which work well on white and black? |
Hi @protz, @xi and @elioqoshi. I took some screenshots of Current state stableCurrent state Beta |
@elioqoshi: Oh and i think what @xi means by keeping theme colors: It seems to me right now Conversations inherits the color palette from TB which in turn inherits it from the currently used color theme of the OS. (Theme colors might rarely/never change on Windows or OS X for a regular user but Linux is a different case.) |
So I think most of the plans here were completed. As it was a while ago, and we've not had much activity since, I'm going to close this out. |
Hi there,
I actually love Conversations and use it for most quick emails I need to write.
As a designer however, it has a bit of an outdated UI, which I'd love to contribute to, its just that I'm not a coder :)
Looking forward to your thoughts!
The text was updated successfully, but these errors were encountered: