Be more careful when deleting an account

Fixes issue 3954
thunderbird · Jan 8, 2012 · 37b26ff · 37b26ff
1 parent d955482
commit 37b26ff
Showing 1 changed file with 13 additions and 6 deletions.
diff --git a/src/com/fsck/k9/Account.java b/src/com/fsck/k9/Account.java
@@ -18,6 +18,7 @@
 import com.fsck.k9.mail.store.StorageManager.StorageProvider;
 import com.fsck.k9.view.ColorChip;
 
+import java.lang.reflect.Array;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Calendar;
@@ -401,18 +402,24 @@ private synchronized void loadAccount(Preferences preferences) {
     }
 
     protected synchronized void delete(Preferences preferences) {
+        // Get the list of account UUIDs
         String[] uuids = preferences.getPreferences().getString("accountUuids", "").split(",");
-        String[] newUuids = new String[uuids.length - 1];
-        int i = 0;
+
+        // Create a list of all account UUIDs excluding this account
+        List<String> newUuids = new ArrayList<String>(uuids.length);
         for (String uuid : uuids) {
-            if (uuid.equals(mUuid) == false) {
-                newUuids[i++] = uuid;
+            if (!uuid.equals(mUuid)) {
+                newUuids.add(uuid);
             }
         }
 
-        String accountUuids = Utility.combine(newUuids, ',');
         SharedPreferences.Editor editor = preferences.getPreferences().edit();
-        editor.putString("accountUuids", accountUuids);
+
+        // Only change the 'accountUuids' value if this account's UUID was listed before
+        if (newUuids.size() < uuids.length) {
+            String accountUuids = Utility.combine(newUuids.toArray(), ',');
+            editor.putString("accountUuids", accountUuids);
+        }
 
         editor.remove(mUuid + ".storeUri");
         editor.remove(mUuid + ".localStoreUri");