IMAPsearch #129
IMAPsearch #129
Conversation
Conflicts: src/com/fsck/k9/activity/MessageList.java
…were previously opened Read-Only.
Tabs -> 4 spaces Remove trailing whitespace from blank lines *NO FUNCTIONAL CHANGES*
…quest. Most code moved out of ImapStore and ImapFolder and into MessagingController.searchRemoteMessagesSynchronous. Should make it easier to add remoteSearch for other server types.
getRemoteSearchFullText -> isRemoteSearchFullText line wraps for preference items
Conflicts: src/com/fsck/k9/mail/store/ImapStore.java src/com/fsck/k9/mail/store/LocalStore.java
| } | ||
| public void searchRemoteMessagesSynchronous(final String acctUuid, final String folderName, final String query, | ||
| final Flag[] requiredFlags, final Flag[] forbiddenFlags, final MessagingListener listener) { | ||
| final Account acct = Preferences.getPreferences(mApplication.getApplicationContext()).getAccount(acctUuid); |
There was a problem hiding this comment.
don't abbreviate names. use "account" instead of "acct".
|
this modified loadMessageForView() to dowload message if neither X_DOWNLOADED_FULL nor X_DOWNLOADED_PARTIAL. it will download the entire message, as i couldn't figure out yet how to set messages under the size limit to X_DOWNLOADED_FULL (couldn't get their size easily). |
|
Is there a reason to make it toggled by a preference rather than just 'always on'? |
|
Hi rbayer. Thank you very much for making android email clients aware of the (really necessary) IMAP "search" feature! |
|
I'm sorry it's taken me so long to review this patch. First, OMG YAY! I'm so thrilled you've taken this on. In terms of user experience - I'd like to find a way for us to decrease the user-facing complexity of this feature - It's a little more daunting than it could be -- and I have a fairly good understanding of what's actually going on. To that end, I think I'd like you to:
Two items I'd love your feedback on: Instead of prompting the user to choose a local or a remote search when they hit the search key, default to doing a local search with a button in the footer view to "Try this search on the server" when the user has started the search from inside a local folder. Instead of having a separate preference for # of search results to get at a time, would you consider using the existing local folder size preference, or does that feel too wrong? If we do that, we can move "Include body text" into Fetching mail -> Advanced -> "Server search includes message bodies" In the longer term, are you considering building out functionality to search multiple server-side folders at once (by iterating over the folders and presenting the results in one view, I guess)? Again, thank you so much for working on this and I'm sorry the UX review took me so long. -jesse |
ghost
assigned 
|
Latest 'master' contains this functionality. |
Basic remote/server-side search functionality for IMAP servers. Activate in preferences on a per-account basis.