ensure that multipart/* parts always have a non-null boundary field #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this do the right thing when a previously partially downloaded mail is downloaded completely? |
|
When a mail is downloaded completely all parts get replaced, don't they? If that is the case, a boundary which comes in this way should be put where expected. We might still want to give the whole boundary deal more thought, see my last comment in #1333. |
Valodim
force-pushed
the
fix-empty-multipart
branch
from
ae98b01
to
e3593a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1333. This makes sure that multipart fields always have a boundary field set in the database by generating a new one if the body of such part is null.