support display of format=flowed (rfc2646) #1835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valodim
force-pushed
the
flowed-display
branch
from
34dad0d
to
0754dce
Compare
Valodim
added
the
type: enhancement
cketti
requested changes
Dec 12, 2016
| @@ -36,6 +36,10 @@ public static void setBody(Part part, Body body) throws MessagingException { | |||
| if (name != null) { | |||
| contentType += String.format(";\r\n name=\"%s\"", name); | |||
| } | |||
| boolean isFlowed = MimeUtility.isFormatFlowed(part.getContentType()); | |||
There was a problem hiding this comment.
We don't support creating format=flowed messages. It looks like this is only for the benefit of the new test in MessageViewInfoExtractorTest. I'd rather have the test set the header after adding the body than adding to this already horrible method.
| @@ -1137,4 +1140,11 @@ public static boolean isMessage(String mimeType) { | |||
| public static boolean isSameMimeType(String mimeType, String otherMimeType) { | |||
| return mimeType != null && mimeType.equalsIgnoreCase(otherMimeType); | |||
| } | |||
|
|
|||
| static boolean isFormatFlowed(String contentType) { | |||
| if (TEXT_PLAIN.equalsIgnoreCase(getHeaderParameter(contentType, null))) { | |||
There was a problem hiding this comment.
Extracting the results of the getHeaderParameter() calls to local variables should make this easier to read.
Valodim
force-pushed
the
flowed-display
branch
from
a85354d
to
a055ed4
Compare
cketti
approved these changes
Jan 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it says on the tin. This supports rfc2646 which specifies format=flowed, but not rfc3676 which adds the delsp parameter. That should be simple to add though.