Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to switch between text/plain and text/html #5656

Closed
wants to merge 3 commits into from

Conversation

tenzap
Copy link

@tenzap tenzap commented Sep 9, 2021

This PR follows #3936 which has not been updated for a while.

It:

  • contains the same changes except I fixed it to work with current code
  • adds a setting to choose the default content-type.

With them, the user can:

  • set the default way to display messages (either plain text or HTML)
  • on a "per demand" basis switch from one to another for the currently displayed message.

Related feature requests: #906 #1397

In case you or anyone is interested, the PR is also available for 5.8 in this branch https://github.com/tenzap/k-9/tree/f/5.8-MAINT/plain_text

Screenshot for the setting is below, other screenshots for per-message basis are in the original PR #3936
Screenshot_1631201917_256p

@tenzap tenzap changed the base branch from main to 5.8-MAINT September 9, 2021 16:17
@tenzap tenzap changed the base branch from 5.8-MAINT to main September 9, 2021 16:18
@dhebbeker
Copy link
Contributor

Thank you @tenzap for pursuing the work.

I stopped maintaining #3936. As I did not have any idea when to expect feedback from the maintainers or what to do, my motivation to keep updating that PR vanished. I guess it would have been nice if the work would have been coordinated. I blame myself for not getting directly in touch with the maintainers to get a perspective. Some of those ways of communication already existed back then. And now there is also the "Discussions" feature in this GitHub project.

But this was long ago. I hope #1397 will be eventually fixed. 🤞

@tenzap tenzap force-pushed the f/plain_text branch 3 times, most recently from 68b26e0 to bb171c6 Compare July 14, 2022 09:43
@tenzap
Copy link
Author

tenzap commented Jul 14, 2022

Hi @cketti , @ByteHamster , now that k-9 is part of the wider thunderbird community, is there a higher chance to see this long requested & awaited feature merged any time soon?

In the meantime I updated it to fit to your latest commits.

For those interested I also refreshed it for these branches 5.8, 6.0 & 6.2. It can be found here:

https://github.com/tenzap/k-9/tree/f/5.8-MAINT/plain_text
https://github.com/tenzap/k-9/tree/f/6.0-MAINT/plain_text
https://github.com/tenzap/k-9/tree/f/6.2-MAINT/plain_text

@cketti cketti closed this Dec 28, 2022
@tenzap
Copy link
Author

tenzap commented Dec 28, 2022

Any explanation why this was closed would have been nice. Has this feature been implemented in the meantime?

@cketti
Copy link
Member

cketti commented Dec 28, 2022

I was closing all old pull requests that can't or won't be merged as-is.

To do this feature properly, some UI/UX design work is required. Simply adding more entries to the menu is not acceptable. The cases where only a text/plain or a text/html part is present should be handled gracefully, etc.

I currently don't consider this feature important enough to warrant spending our time to do this properly. If you're volunteering to put in the necessary work, I can check if our designers are available for a meeting in January.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants