New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change autoconfig code to match Thunderbird's current behavior #6860
Conversation
Have different implementations for an autoconfig server hosted by the email provider (`ProviderAutoconfigUrlProvider`) and the ISP DB (`IspDbAutoconfigUrlProvider`).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
You can test this against my autoconfig server project https://github.com/wdes/mail-autodiscover-autoconfig#tested-working-apps
Can you provide a debug build so I can test this and provide feedback?
Ref: #865 (comment) Probably:
This implementation probably misses SRV record lookup, that would be game changer compared to other existing email apps. Probably good for another PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I tried the pre-release build and it seems to not work better than before. The imap server settings are still wrong |
The code isn't used by the app right now. |
Okay, thanks for letting me know |
The set of URLs checked by Thunderbird are slightly different from what I thought when reading the documentation.
https://searchfox.org/comm-central/rev/f1c212acd8e3c3c2d1f5e2d442bb66e1407243b5/mail/components/accountcreation/FetchConfig.jsm#94-154