Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change autoconfig code to match Thunderbird's current behavior #6860

Merged
merged 3 commits into from May 3, 2023

Conversation

cketti
Copy link
Member

@cketti cketti commented Apr 28, 2023

The set of URLs checked by Thunderbird are slightly different from what I thought when reading the documentation.

https://searchfox.org/comm-central/rev/f1c212acd8e3c3c2d1f5e2d442bb66e1407243b5/mail/components/accountcreation/FetchConfig.jsm#94-154

@cketti cketti requested a review from wmontwe April 28, 2023 15:15
Copy link

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me
You can test this against my autoconfig server project https://github.com/wdes/mail-autodiscover-autoconfig#tested-working-apps

Can you provide a debug build so I can test this and provide feedback?

@williamdes
Copy link

Ref: #865 (comment)

Probably:

This implementation probably misses SRV record lookup, that would be game changer compared to other existing email apps. Probably good for another PR

Copy link
Collaborator

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cketti cketti merged commit 1de8205 into main May 3, 2023
2 checks passed
@cketti cketti deleted the autoconfig_provider branch May 3, 2023 14:53
@williamdes
Copy link

Looks good to me You can test this against my autoconfig server project https://github.com/wdes/mail-autodiscover-autoconfig#tested-working-apps

Can you provide a debug build so I can test this and provide feedback?

I tried the pre-release build and it seems to not work better than before. The imap server settings are still wrong

@cketti
Copy link
Member Author

cketti commented May 8, 2023

The code isn't used by the app right now.

@williamdes
Copy link

The code isn't used by the app right now.

Okay, thanks for letting me know
Looking forward to test this when it's available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants