Fix `NullPointerException` by avoiding race condition #7689

cketti · 2024-03-04T13:27:45Z

Fixes a crash reported via Google Play (K-9 Mail 6.800).

Exception java.lang.NullPointerException: Attempt to invoke virtual method 'void android.app.ProgressDialog.setProgress(int)' on a null object reference
  at com.fsck.k9.fragment.AttachmentDownloadDialogFragment$1.updateProgress (AttachmentDownloadDialogFragment.java:48)
  at com.fsck.k9.controller.MessagingController$4$1.updateProgress (MessagingController.java:1352)
  at com.fsck.k9.controller.ProgressBodyFactory$1.run (ProgressBodyFactory.java:29)
  at java.util.TimerThread.mainLoop (Timer.java:563)
  at java.util.TimerThread.run (Timer.java:513)

wmontwe

👍

I added a ticket to address the ProgressDialog deprecation warnings: #7696

wmontwe · 2024-03-05T09:59:49Z

app/ui/legacy/src/main/java/com/fsck/k9/fragment/AttachmentDownloadDialogFragment.java

@@ -42,6 +41,14 @@ public Dialog onCreateDialog(Bundle savedInstanceState) {

        final SizeUnit sizeUnit = SizeUnit.getAppropriateFor(size);

+        ProgressDialog dialog = new ProgressDialog(getActivity());


We should use requireActivity(), it is not null and helps converting this class to Kotlin later. Also the generated error messages are more helpful for debugging.

Suggested change

ProgressDialog dialog = new ProgressDialog(getActivity());

ProgressDialog dialog = new ProgressDialog(requireActivity());

We could add a lint check to assist here. I'll create one when I have some spare time. #7695

Fix NullPointerException by avoiding race condition

91f6198

cketti requested a review from wmontwe as a code owner March 4, 2024 13:27

cketti changed the base branch from main to 6.8-MAINT March 4, 2024 14:41

wmontwe approved these changes Mar 5, 2024

View reviewed changes

cketti merged commit c9b74b1 into 6.8-MAINT Mar 5, 2024
2 checks passed

cketti deleted the avoid_crash_when_downloading_attachment branch March 5, 2024 12:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix `NullPointerException` by avoiding race condition #7689

Fix `NullPointerException` by avoiding race condition #7689

cketti commented Mar 4, 2024

wmontwe left a comment •

edited

wmontwe Mar 5, 2024 •

edited

wmontwe Mar 5, 2024 •

edited

		@@ -42,6 +41,14 @@ public Dialog onCreateDialog(Bundle savedInstanceState) {

		final SizeUnit sizeUnit = SizeUnit.getAppropriateFor(size);

		ProgressDialog dialog = new ProgressDialog(getActivity());

Fix NullPointerException by avoiding race condition #7689

Fix NullPointerException by avoiding race condition #7689

Conversation

cketti commented Mar 4, 2024

wmontwe left a comment • edited

Choose a reason for hiding this comment

wmontwe Mar 5, 2024 • edited

Choose a reason for hiding this comment

wmontwe Mar 5, 2024 • edited

Choose a reason for hiding this comment

Fix `NullPointerException` by avoiding race condition #7689

Fix `NullPointerException` by avoiding race condition #7689

wmontwe left a comment •

edited

wmontwe Mar 5, 2024 •

edited

wmontwe Mar 5, 2024 •

edited