Don't allow username or password to contain line break #7693
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much of our protocol code isn't prepared to deal with line breaks in the username or password. Since IMAP, POP3, and SMTP are line-based protocols, this could lead to command injection. We avoid this by not allowing the username and password in
ServerSettings
to contain line breaks.We still need to make sure we don't allow the user to enter such values (see #7670).