Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full description reworked #7770

Closed
wants to merge 1 commit into from
Closed

Conversation

comradekingu
Copy link
Contributor

Copy link
Member

@cketti cketti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for trying to improve the app description 👍

These are quite a few unrelated changes. In general it's easier to discuss changes when it's just one topic. The individual changes in this PR are small enough that it's fine to have them all in one PR. But it would have been nice to have multiple commits for the different changes ("email" → "e-mail", capitalizing bullet points, simplifying the language).

@@ -1,24 +1,22 @@
K-9 Mail is an open source email client that works with basically every email provider.
Open source e-mail client that works with basically every e-mail provider.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why drop the application name?

@@ -1,24 +1,22 @@
K-9 Mail is an open source email client that works with basically every email provider.
Open source e-mail client that works with basically every e-mail provider.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We consistently use "email" throughout the app, not "e-mail".

K-9 Mail is a community developed project. If you're interested in helping to improve the app, please join us!
You can find our bug tracker, source code, and wiki at <a href="https://github.com/thunderbird/thunderbird-android">https://github.com/thunderbird/thunderbird-android</a>.
We're always happy to welcome new developers, designers, documenters, translators, bug triagers and friends.
K-9 Mail is a community developed project. Help improve the app. Join us!
Copy link
Member

@cketti cketti Apr 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this. If you simplify the language too much, it ends up sounding like a Dalek.

You can find our bug tracker, source code, and wiki at <a href="https://github.com/thunderbird/thunderbird-android">https://github.com/thunderbird/thunderbird-android</a>.
We're always happy to welcome new developers, designers, documenters, translators, bug triagers and friends.
K-9 Mail is a community developed project. Help improve the app. Join us!
The bug tracker, source code, and wiki is at <a href="https://github.com/thunderbird/thunderbird-android">https://github.com/thunderbird/thunderbird-android</a>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an enumeration of three things. Shouldn't then "are" be used instead of "is"?

@cketti
Copy link
Member

cketti commented May 6, 2024

Closing this pull request since no answers were provided.

I created #7812 to change the capitalization of the bullet points.

@cketti cketti closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants