Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If selected, send client certificate before password auth #780

Closed
wants to merge 3 commits into from

Conversation

gaionim
Copy link
Contributor

@gaionim gaionim commented Sep 6, 2015

Changes seems harmless to me except userInfo pack and unpack.

widget for client certificate is always visible

all auth type ( I've tested only plain) sends cliantCertificateAlias
for me works both with certificate ( my server)
and without cert ( gmail)

userInfo pack and unpack seems weak, but I lack skills to fix

Changes seems harmless to me except userInfo pack and unpack.

    widget for client certificate is always visible

    all auth type ( I've tested only plain) sends cliantCertificateAlias
    for me works both with certificate ( my server)
    and without cert ( gmail)

    userInfo pack and unpack seems weak, but I lack skills to fix
@cketti
Copy link
Member

cketti commented Sep 12, 2015

Thanks for your work! I like the feature.

But extending the already horrible mechanism of storing credentials in URIs is not an option. We need to change the way we store server settings/credentials first. And only then add more authentication combinations. I created issue #793 to track this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants